Re: Splitting out transfer from main shell
By: Nelgin to Digital Man on Thu Mar 16 2023 02:06 am
Re: Splitting out transfer from main shell
By: Digital Man to Nelgin on Wed Mar 15 2023 22:06:45
Different command shells have traditionally very different file transfer sections/menus (from the other command shells), so I don't really see the value in that.
It just seems like a logical step. You've got the 5 major functions, email/netmail, file transfers, external programs, text area, and chat.
It just seems cleaner and logical to have a "main" menu and then control everything else from their own .js file. Otherwise, why separate all the other parts out.
I only did that for reuse in Baja command shells. I don't think anybody wants to reuse a single file transfer section among multiple command shells.
I think making the transfer section its own sec.js would
pretty much round things off.
I think it would involve a lot of copy and paste of code unnecessarily. If you look at default.js, the only difference between the main/message section and he file transfer section is a data. The code is exactly the same - so why copy it to another file? That doesn't make sense to me.
There could then be an xfer_sec in the
loadable modules (and maybe add email_sec too)?
I don't see that serving a purpose.
The email_sec having its own loadable module configuration is a separate discussion, but since there was never an "email_sec" Baja function, there was no way to invoke such a loadable module in the first place (from a command shell written in Baja).
It just points to a cleaner, modular design. It's just odd having transfers in there.
I don't think so.
If it's not something you want to do then I may just end up doing it myself and hope for the best.
If you're writing your own command shell, certainly split things up however you like or see as best. In the command shell that I wrote in JS (default.js), the main/message and file transfer sections share the same code/logic, so splitting into multiple files made no sense. It's certainly not a big file. And I don't see any *other* command shells wanting to re-use just my file transfer menu/section. Other command shells typically use a very different layout and set of command keys and even look/feel/style (prompts, etc.).
--
digital man (rob)
Synchronet "Real Fact" #61:
How to get Synchronet technical support:
http://wiki.synchro.net/howto:support Norco, CA WX: 50.0øF, 97.0% humidity, 0 mph SE wind, 0.35 inches rain/24hrs
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net